is_num_equivalent returns False for 1000 and 1,000

juditacs / semeval

MathLing Budapest Team's repo

MIT License

10 stars 9 forks source link

is_num_equivalent returns False for 1000 and 1,000 #21

Closed recski closed 9 years ago

recski commented 9 years ago

Because commas are replaced by periods and then treated as decimal points, so I guess 1,000 becomes 1. My suggestion is to simply discard commas: AFAIK they are never used as decimal points in the U.S.

juditacs commented 9 years ago

This was fixed by https://github.com/juditacs/semeval/pull/23

I ran

echo "1000    1,000" | python src/align_and_penalize.py lsa

And it detects equal numbers.

I'm closing this issue.