search

judithabk6 / med_bench

BSD 3-Clause "New" or "Revised" License
8 stars 3 forks source link

Fixes theoretical effects #24 #28

Closed judithabk6 closed 1 year ago

bthirion commented 1 year ago

Great ! Is there a test that enforces the new behavior ?

judithabk6 commented 1 year ago

this test tests the sum of effects, which is how we detected the issue https://github.com/judithabk6/med_bench/blob/aec6d2145957c80f47dd7cc59ee6d9e32e7b933b/tests/simulate_data/test_get_simulated_data.py#L116

wdyt? would you add more tests?

bthirion commented 1 year ago

LGTM.

bthirion commented 1 year ago

Merging, then.