search

judithabk6 / med_bench

BSD 3-Clause "New" or "Revised" License
8 stars 3 forks source link

Make R dependency optional #49

Open bthirion opened 10 months ago

bthirion commented 10 months ago

It literally took ma hours to install R dependencies. We should make them optional and reimplement in Python whatever can be implemented in Python

judithabk6 commented 10 months ago

yes, that is what this #40 starts to do. wdyt? it allows to use the Python implemented estimators without loading anything R-related

bthirion commented 10 months ago

OK, perfect ! For project monitoring, it is important to open issues first and then PRs.

judithabk6 commented 10 months ago

some example of how it is handled in nilearn https://github.com/nilearn/nilearn/blob/main/nilearn/plotting/tests/test_surf_plotting.py#L258

(optional import, then import error if not loaded, and optional tests if not loaded)