search

judithabk6 / med_bench

BSD 3-Clause "New" or "Revised" License
8 stars 3 forks source link

Data simulation - Misuses prohibiton #6

Open sami6mz opened 1 year ago

sami6mz commented 1 year ago

In get_simulated_data.py, simulate_data() :

If one sets n = 0, several warnings are returned. Outputs are NaN or empty arrays. We could prohibit the misuses n <= 0, dim_x <= 0 and dim_m <= 0.

judithabk6 commented 7 months ago

@bthirion maybe we should do something about this. Should there be a check input, or check that there are no NaN before returning the result (with an insightful warning or error raise if there are NaNs)?

bthirion commented 7 months ago

Indeed.