search

judithabk6 / med_bench

BSD 3-Clause "New" or "Revised" License
8 stars 3 forks source link

Failing estimators with input shape (n,1) #75

Open brash6 opened 6 months ago

brash6 commented 6 months ago

Some estimators are failing when t and y have a shape of (n,1). Hence, we need to use ravel()function from numpy and make them 1D dimension to avoid the error.

This behaviour may need to be investigated and solved as discussed in https://github.com/judithabk6/med_bench/pull/74#discussion_r1529335373

judithabk6 commented 6 months ago

this is related to #57 (and hence #14 and #41) Does this need to be done in #74? how do you think we should proceed? address the three behaviors separately or try to have a general "input checker" function? @bthirion @brash6

bthirion commented 6 months ago

Not necessarily. I'm in favor of small, well-targeted PRs.