Input check - Githubissues

judithabk6 / med_bench

BSD 3-Clause "New" or "Revised" License

8 stars 3 forks source link

Input check #80

Closed judithabk6 closed 3 months ago

judithabk6 commented 3 months ago

addresses #75 #57 #14 #41
implementation of an input checker for all estimators
adding ravel of m when needed
removes the xfail of the test_robustness_to_ravel format (https://github.com/judithabk6/med_bench/blob/4ebee9c7ae7ff59b1c6c4f9ad333a552b719eece/src/tests/estimation/test_get_estimation.py#L257)

still a draft (I know there are commented lines to remove or this sort of things), I have issues with

exact tests, not sure why
maybe it is the occasion to deal with the reshapes in the src/med_bench/utils/nuisances.py file (need some input on how it should be done @houssamzenati)

I open the PR to discuss if the main direction is ok for everyone