search

judos / hardCrafting

Factorio mod - harder ressource processing
GNU General Public License v3.0
6 stars 13 forks source link

Steel Dist recipie costs zero #28

Closed thorsummoner closed 7 years ago

thorsummoner commented 7 years ago

fixed by #27

GodricSeer commented 7 years ago

I am not sure if simply setting a minimum of 1 is the correct solution to this. Steel from iron plates costs 5 plates, which is somewhere between 4 and 5 crushed iron. The automatic calculations is supposed to make the recipe about 20% more efficient than making steel from plates, so it should cost 3-4 crushed iron, but this fix would make it only cost 1. While this fixes the 0 cost recipe, there is still a more fundamental problem in the calculation of the steel recipes.

judos commented 7 years ago

Well for now i go with the "minimum 1", if the recipes are changed with a different mod it is hard to stay consistent and balanced. Maybe if you give some more hints to the other mods which change these recipes we can find a better approach.

judos commented 7 years ago

oh, I just saw now that there is a general problem with the calculation of iron-plates needed to smelt steel-plates. Therefore yes before it was actually not working at all. And of course the minimum of 1 item is far too few. It's intended to be 4 items instead of the usual 5. The calculation will be fixed with v0.5.5, but also the minimum of 1 i leave if any other mods change the recipe...

thorsummoner commented 7 years ago

it would probably be good to clamp any values to expected ranges. i don't know if this is done anywhere else in the mod- hope the maintainer is aware

On May 25, 2017 7:20 AM, "Julian" notifications@github.com wrote:

oh, I just saw now that there is a general problem with the calculation of iron-plates needed to smelt steel-plates. Therefore yes before it was actually not working at all. And of course the minimum of 1 item is far too few. It's intended to be 4 items instead of the usual 5. The calculation will be fixed with v0.5.5, but also the minimum of 1 i leave if any other mods change the recipe...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/judos/hardCrafting/issues/28#issuecomment-304021975, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQlkFnQTjURo1RU9o06Z6eSGg3Uo0mDks5r9Y4qgaJpZM4NhXZ_ .