judos / robotMiningSite

A factorio mod
GNU General Public License v3.0
5 stars 2 forks source link

Item stack doesn't have name parameter #3

Closed Greywizz closed 8 years ago

Greywizz commented 8 years ago

Hi Nice little mod but as you can tell by the screen shot i get the error and this is what i have done.

  1. i have put it next to the roboport and still get the error
  2. moved it away from the roboport and still get the error
  3. started a new game and it doing the same

so i just want to let you know

thanks once again

screenshot_2

VaelophisNyx commented 8 years ago

I found that if a building is in the mining area it can cause that error.

judos commented 8 years ago

Thanks for the report. I guess you have used version 0.1.1. What building are you placing there? Please provide a save game + mods such that I can reproduce the issue and fix it.

VaelophisNyx commented 8 years ago

I don't have a save with it atm, but I can tell you how to reproduce it hopefully: Find any ore that is under a building, have more drones than can be used in the mining area and place the mining site to where the area includes the ore beneath it(or a building at all). I think it tries to mine the building but it doesn't have a "stack" assigned to it.

VaelophisNyx commented 8 years ago

Also it sometimes ignores things like power poles and belt.

judos commented 8 years ago

Hmm I tried this but that didn't cause the error. However with 0.1.3 the ore will now longer be mined below any building/entity. This should also resolve this issue :)

VaelophisNyx commented 8 years ago

Ah. I was actually using 0.1.2 but had used 0.1.1 so I knew of the error. if I encounter it I'll update this issue with a save and mod list.

judos commented 8 years ago

Ok great. I will close it for now.

judos commented 8 years ago

The issue is reproducible for Ore's that have mining results of which the item name differs from the entity name. The error message is confusing because there is a stack.name but no item can be found under this name. Will be definitely fixed in 0.2.0 (soon).

VaelophisNyx commented 8 years ago

I'm going to point you to the Automated Red Alert Harvester mod, as it tackled this issue.