search

judovana / java-runtime-decompiler

GNU General Public License v3.0
68 stars 14 forks source link

Overrides for fs vm #165

Closed judovana closed 3 years ago

judovana commented 3 years ago

Follwoing the https://github.com/pmikova/java-runtime-decompiler/pull/159 fixing: https://github.com/pmikova/java-runtime-decompiler/issues/161 finishing: https://github.com/pmikova/java-runtime-decompiler/issues/153 https://github.com/pmikova/java-runtime-decompiler/issues/152

AurumTheEnd commented 3 years ago

You know that the feature is Overwrites and not Overrides, right?

judovana commented 3 years ago

Is there a difference?

-- Mgr. Jiri Vanek @.***

---------- Původní e-mail ---------- Od: Prokop Tunel @.> Komu: pmikova/java-runtime-decompiler @. github.com> Datum: 3. 10. 2021 14:35:49 Předmět: Re: [pmikova/java-runtime-decompiler] Overrides for fs vm (#165) "

You know that the feature is Overwrites and not Overrides, right?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (https://github.com/pmikova/java-runtime-decompiler/pull/165#issuecomment-932942129) , or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAWFCS4KKQGQD6USTWVWPEDUFBEZ7ANCNFSM5FHRVAQQ) . Triage notifications on the go with GitHub Mobile for iOS (https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or Android (https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub) . "

AurumTheEnd commented 3 years ago

Is there a difference?

Well... not really, which is why I guess the HashMap was already misnamed in org/jrd/agent/Transformer.java. But it is good for user experience to stick to the name of a feature everywhere it's reference. Hence for example a portion of this commit: dd8ec5a628316366cf4998e988cf0ee165d465fa

judovana commented 3 years ago

I definitely agree with the good experinece casued by consistent naming!

-- Mgr. Jiri Vanek @.***

---------- Původní e-mail ---------- Od: Prokop Tunel @.> Komu: pmikova/java-runtime-decompiler @. github.com> Datum: 3. 10. 2021 15:23:51 Předmět: Re: [pmikova/java-runtime-decompiler] Overrides for fs vm (#165) "

" Is there a difference? " Well... not really, which is why I guess the HashMap was already misnamed in org/jrd/agent/Transformer.java. But it is good for user experience to stick to the name of a feature everywhere it's reference. Hence for example a portion of this commit: dd8ec5a (https://github.com/pmikova/java-runtime-decompiler/commit/dd8ec5a628316366cf4998e988cf0ee165d465fa)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (https://github.com/pmikova/java-runtime-decompiler/pull/165#issuecomment-932950578) , or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAWFCS45AGWFLPHYBEQ2X6TUFBKOFANCNFSM5FHRVAQQ) . Triage notifications on the go with GitHub Mobile for iOS (https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or Android (https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub) . "