search

judovana / java-runtime-decompiler

GNU General Public License v3.0
68 stars 14 forks source link

revisit github actions test conditions #178

Closed judovana closed 2 years ago

judovana commented 2 years ago

Why there is this condition at all? Test all! Also the -DfailIfNoTests=false seems wrong. lets fail

Originally posted by @judovana in https://github.com/pmikova/java-runtime-decompiler/pull/175#r725445348

judovana commented 2 years ago 
 mvn --batch-mode test -Dtest=*CliTest -DfailIfNoTests=false

should be just

 mvn --batch-mode test
AurumTheEnd commented 2 years ago

-DfailIfNoTests=false is there because by default, mvn fails if it finds no tests (error message is "No tests were executed!"), for example in the decompiler_agent module. That fails the whole test run and we don't want that.

... it should be just mvn --batch-mode test.

All the other tests are run in the Build JRD with Maven step, I see no point in repeating them here.