search

judovana / java-runtime-decompiler

GNU General Public License v3.0
68 stars 14 forks source link

CPLC prepare for API break #188

Closed mkoncek closed 2 years ago

mkoncek commented 2 years ago

Do not merge yet. The shell scripts for images still need to be changed.

mkoncek commented 2 years ago

This would be mergeable after i release cplc 1.7.

judovana commented 2 years ago

hm.. I do not see a stopper. But as you wish

-- Mgr. Jiri Vanek @.***

---------- Původní e-mail ---------- Od: mkoncek @.> Komu: pmikova/java-runtime-decompiler @. github.com> Datum: 14. 10. 2021 10:12:01 Předmět: Re: [pmikova/java-runtime-decompiler] CPLC prepare for API break (# 188) "

This would be mergeable after i release cplc 1.7.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub (https://github.com/pmikova/java-runtime-decompiler/pull/188#issuecomment-943119217) , or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAWFCS6VOD7RDIA6W3LJMYLUG2GETANCNFSM5F4VWHCQ) . Triage notifications on the go with GitHub Mobile for iOS (https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or Android (https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub) . "

judovana commented 2 years ago

looks good. ty!

judovana commented 2 years ago

hm.. I do not see a stopper. But as you wish … -- Mgr. Jiri Vanek @. ---------- Původní e-mail ---------- Od: mkoncek @.> Komu: pmikova/java-runtime-decompiler @.*** github.com> Datum: 14. 10. 2021 10:12:01 Předmět: Re: [pmikova/java-runtime-decompiler] CPLC prepare for API break (# 188) " This would be mergeable after i release cplc 1.7. — You are receiving this because you commented. Reply to this email directly, view it on GitHub (#188 (comment)) , or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAWFCS6VOD7RDIA6W3LJMYLUG2GETANCNFSM5F4VWHCQ) . Triage notifications on the go with GitHub Mobile for iOS (https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or Android (https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub) . "

I mean one canalways build agaisnt local install of cplc

mkoncek commented 2 years ago

1.7 released, i retriggered the CI.

AurumTheEnd commented 2 years ago

@mkoncek sad to not see start.bat updated. Oh well, will add separately.

mkoncek commented 2 years ago

unfortunately i have never worked with .bat files and i cannot test it.

judovana commented 2 years ago

:)

In this case it is just copypasting, but sure. Poor ohrdlicka never worked with netopyrs to, and is doing his best...

-- Mgr. Jiri Vanek @.***

---------- Původní e-mail ---------- Od: mkoncek @.> Komu: pmikova/java-runtime-decompiler @. github.com> Datum: 14. 10. 2021 18:29:18 Předmět: Re: [pmikova/java-runtime-decompiler] CPLC prepare for API break (# 188) "

unfortunately i have never worked with .bat files and i cannot test it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub (https://github.com/pmikova/java-runtime-decompiler/pull/188#issuecomment-943521158) , or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAWFCS2Y5LAWSLXOOEW4MEDUG4ANRANCNFSM5F4VWHCQ) . Triage notifications on the go with GitHub Mobile for iOS (https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or Android (https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub) . "

AurumTheEnd commented 2 years ago

:) In this case it is just copypasting, but sure. Poor ohrdlicka never worked with netopyrs to, and is doing his best...

Working with netopyrs turns out to be a real showstopper :)