search

judovana / java-runtime-decompiler

GNU General Public License v3.0
68 stars 14 forks source link

Merged the usages of findAgent() and getPossibleAgentLocation() - version 1 #192

Closed AurumTheEnd closed 3 years ago

AurumTheEnd commented 3 years ago

Context: Once upon a time @judovana and @AurumTheEnd commited a similar feature (guessing the location of a .jar on the filesystem) and both of the commits got merged into master - 83ae08cfc7f915e3dd7c1588662c68e5487b0083 & 168b1aa02450a9c850b89ab9e780a0f844461781. When it came to resolving duplicate code, they both had different ideas of resolution, and could not make a compromise. Thus, this PR and its sister PR were born, to allow a vote of who did fixed it better. You do not know who made what, you can only look for yourself and vote below.

AurumTheEnd commented 3 years ago

Vote here for 1.1: https://doodle.com/poll/6wdu6cssqtcntbgw?utm_source=poll&utm_medium=link

judovana commented 3 years ago

based on https://doodle.com/poll/6wdu6cssqtcntbgw/ closing