search

judovana / java-runtime-decompiler

GNU General Public License v3.0
68 stars 14 forks source link

WIP: Fixing issues #201

Closed AurumTheEnd closed 2 years ago

AurumTheEnd commented 2 years ago

Addresses #124.

judovana commented 2 years ago

kudos., awesome work. Need to read it second times

judovana commented 2 years ago

isnt better to pass the vrbose from global settings? Like that, also the quick compile/quick compiel and uplaod will get use of it.

AurumTheEnd commented 2 years ago

isnt better to pass the vrbose from global settings? Like that, also the quick compile/quick compiel and uplaod will get use of it.

You mean abusing our Config singleton designed to operate on our config file to to also hold cross-class non-saved data? Sure, could be done. I don't think that's good practice tho.

AurumTheEnd commented 2 years ago

I guess the WIP did not stop you from merging it, huh.

judovana commented 2 years ago

Of course not. It was not WIP. It was many self contained and finished changes.

-- Mgr. Jiri Vanek @.***

---------- Původní e-mail ---------- Od: Prokop Tunel @.> Komu: pmikova/java-runtime-decompiler @. github.com> Datum: 20. 10. 2021 14:41:33 Předmět: Re: [pmikova/java-runtime-decompiler] WIP: Fixing issues (PR #201) "

I guess the WIP did not stop you from merging it, huh.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub (https://github.com/pmikova/java-runtime-decompiler/pull/201#issuecomment-947626044) , or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAWFCS6VPYWABSVPKDWRJJ3UH22HHANCNFSM5GI2AUPA) . Triage notifications on the go with GitHub Mobile for iOS (https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or Android (https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub) . "