search

judovana / java-runtime-decompiler

GNU General Public License v3.0
68 stars 14 forks source link

Replace all `import foo.*;` with explicit fully qualified imports #203

Closed mkoncek closed 2 years ago

mkoncek commented 2 years ago

Please, why? It's 2021, we have IDEs. I cannot edit the source code in Eclipse because it would refactor half of the source file.

judovana commented 2 years ago

Hi!

Sorry, i think I do not follow. What this issue mean?

judovana commented 2 years ago

import . is ususally bad idea and aually there is no reason for it. Simialrly the static imprt. The eclisp eautoformatter can be configured so it do not use import nor static imports. I would encourage you to set it up.

mkoncek commented 2 years ago

Sorry, i should have been more clear, i mean the usage of import foo.*; in the code. Try running grep -r 'import .*\.\*' on the project root.

judovana commented 2 years ago

I see. so you have oposite problem then I guessed. And actually your issue is aligned wth my mindset. I hate * imports. Feel free to refactor and push.

-- Mgr. Jiri Vanek @.***

---------- Původní e-mail ---------- Od: mkoncek @.> Komu: pmikova/java-runtime-decompiler @. github.com> Datum: 20. 10. 2021 12:56:21 Předmět: Re: [pmikova/java-runtime-decompiler] Import foo.* (Issue #203) "

Sorry, i should have been more clear, i mean the usage of import foo.; in the code. Try running grep -r 'import ..*' on the project root.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub (https://github.com/pmikova/java-runtime-decompiler/issues/203#issuecomment-947553385) , or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAWFCS34Y7DJIHIHRTVFCZTUH2N43ANCNFSM5GLJKACQ) . Triage notifications on the go with GitHub Mobile for iOS (https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or Android (https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub) . "

AurumTheEnd commented 2 years ago

I am still not sure what you mean. The title of this issue is still too verbose - do you like and want foo.* or hate it and want it removed?

If you hate "star imports" as they are called, then there should be no problem - checkstyle hates them too. When designing the checkstyle configuration in 469266c53f41b28baea0b9006c0bf4bf05948640, I decided to make an exception for awt.* and swing.*, because these would require changing... well all of the files, and I was lazy. That can the the only point of contention here and sure, deserves an issue (albeit a little more specific)

If you like and want "start imports"... why?