Add jdk 17 to Java CI checks

judovana / java-runtime-decompiler

GNU General Public License v3.0

68 stars 14 forks source link

Add jdk 17 to Java CI checks #239

Closed dupliaka closed 2 years ago

dupliaka commented 2 years ago

During Devconf I have tried to build JRC with JDK17 but failed. I made a small change to PR check so you can see what is happening there. You need to approve running workflow though. Or see the results here: https://github.com/dupliaka/java-runtime-decompiler/runs/4991200164?check_suite_focus=true

judovana commented 2 years ago

Hello!

Thanx for contribution. I can see both master and 6.1 in current state passing on jdk17. The tests are bit.. unstable, but without them it is good. Anyway, the PR is worthy in all cases. TY!

judovana commented 2 years ago

The jdk.jdeps does not export com.sun.tools.javap to unnamed module @0x6c38726a is known thing, And I would swear it was already handed. Obviously some part was missed. And I guess which one.

THnax!

judovana commented 2 years ago

jdk17 should be fied by: https://github.com/pmikova/java-runtime-decompiler/commit/e3c0f7723350c99892dfb1d74a009aea70fdf8d2 https://github.com/pmikova/java-runtime-decompiler/commit/6352db0acb59857f3bad04faafa8e15b413e2c19

thanx a lot for reporting