search

judwhite / IdSharp

.NET ID3 Tagging Library
http://www.idsharp.com
MIT License
54 stars 22 forks source link

Add support for iTunes podcast frames #1

Closed kiliman closed 13 years ago

kiliman commented 13 years ago

Hi Jud. First of all let me say thanks for creating such an awesome ID3 tagging library. I've tried many and this is the first that is not only full-featured, but easy to modify as well.

I needed the ability to add .mp3 files to iTunes and have it be recognized as a Podcast without having to manually set it. Through some Googling and trial and error, I figured out which frames needed to be present for iTunes to treat it as a Podcast.

Anyway, I added support for the following frames if you want to merge it in. Thanks again and let me know if you have any questions.

The following frames were added: ID3/PCST - flag ID3/TCAT - Series Category ID3/TDES - Episode Description ID3/TGID - Episode URL ID3/WFED - Podcast feed URL (not a true WURL frame, but a Text frame with encoding byte)

kiliman commented 13 years ago

Yuck, I just noticed that only half my commit was pushed. Also, it looks like a CRLF issue since it shows I've changed every line. Ugh, git can be a pain at times.

Let me fix by push and I'll get back to you.

Sorry about that.

kiliman commented 13 years ago

Ok, this one seems to have fixed it. Sorry again.

Let me know if you have any problems.

Thanks!

judwhite commented 13 years ago

Hey, thanks for the additions. I made a few notes, looks really good though. Can you supply the documentation you used to research these iTunes frames? If you'd like you can just make a comment at the top of FrameContainer with URLs or possibly a full description copy/pasted in case the link goes dead. I believe there are some examples in the code already. Thanks again!

kiliman commented 13 years ago

Hmm.. I'm not seeing anything outside the standard XML documentation in your code. Can you give me a specific example of the type of documentation you want?

BTW: the "documentation" I found online was simply people asking on forums about it. This link is the most detailed http://forums.whirlpool.net.au/archive/928786

I've also made the changes you've requested and will be pushing that shortyl.

kiliman commented 13 years ago

BTW: I'm on the NuGet team (http://nuget.codeplex.com). This would make an excellent nuget package.