search

jue89 / node-systemd-journald

Native bindings to journald
MIT License
28 stars 10 forks source link

Update for node 12 #14

Closed spion closed 5 years ago

spion commented 5 years ago

Attempted to fix the module to make it build with newest NaN and node v12.

Wonder if its possible to setup a Travis matrix to run tests on various different node versions.

spion commented 5 years ago

Travis build https://travis-ci.org/spion/node-systemd-journald/builds/527905297

jue89 commented 5 years ago

Thank you for your contribution! :) Will have a closer look on your PR within the next days.

jue89 commented 5 years ago

Sry for the delayed response.

I tested some compatibility. All in all everything looks good to me. But I am not able to run the module on Node 0.10 and 0.12. I know they are dinosaurs but I am looking for a quick solution to make the module working on these versions, as well. The stats are showing that the module has several hundred downloads per week. Thus, keeping as much compatibility as possible is a good thing in my opinion ...

spion commented 5 years ago

Would bumping semver-major to 2.0 be acceptable? Users of older node would continue to use the 1.x version which works perfectly fine...

spion commented 5 years ago

I believe the latest build will work down to 0.10:

https://travis-ci.org/spion/node-systemd-journald

jue89 commented 5 years ago

Wow! You rock! :) Thank you for your effort put into this PR. I think this should be ready to merge. I will test again and merge tonight.

jue89 commented 5 years ago

And merged ... thank you again!