search

jue89 / node-systemd-journald

Native bindings to journald
MIT License
28 stars 10 forks source link

Allow specifying the syslog identifier #8

Closed bryanburgers closed 7 years ago

bryanburgers commented 7 years ago

Set the syslog identifier by setting log.identifier to the preferred identifier.

This replaces the reliance on process.title, which has limitations, according to the node docs.

Addresses #7.

jue89 commented 7 years ago

If you haven't done already, I'm going to change your PR according to our discussion in #7 tomorrow evening (GMT+1) and push them into my develop branch for you and would like to hear your thoughts on that.

jue89 commented 7 years ago

Hey Bryan,

sorry for being late. I pushed a feature branch: https://github.com/jue89/node-systemd-journald/tree/feature/default-fields

I actually hadn't to break the interface :) I separated it into a static part (without the default fields feature) and an "instance-based" part (with the default fields feature). The docu hasn't been updated yet. Please have a look into you unit tests for details. I updated them.

What do you think?

bryanburgers commented 7 years ago

Looking great to me! Nice work.

jue89 commented 7 years ago

I'm going to update docu soon and then merge everything to master. Thanks again!

jue89 commented 7 years ago

And published :)