search

jue89 / node-systemd-journald

Native bindings to journald
MIT License
28 stars 10 forks source link

Should use priority string if converting to integer fails #9

Closed spion closed 6 years ago

spion commented 6 years ago

https://github.com/jue89/node-systemd-journald/blob/12b17eed79bb9d385a75abb1128ced7d0e631d29/src/journal_send.cc#L50-L61

jue89 commented 6 years ago

Hey!

Sorry for responding late.

Can you describe your problem a little bit more? I don't see what you expect the C++ bindings to do? Since the send function is called by the library itself and not the user, it should not be possible to call this function with something different than a number. Honestly, the check if the first argument is really a number is kind of redundant. But I'm not brave enough to remove it ;)

spion commented 6 years ago

Never mind - it seems like the problem is with winston-journald, not systemd-journald. Thanks!