search

juergenH87 / python-can-j1939

The package provides SAE J1939 support for Python developers
MIT License
85 stars 49 forks source link

ECU connected using pcan not notifying subscribers #19

Open jedpop opened 2 years ago

jedpop commented 2 years ago

I found that when the ECU is connected using socketcan, subscribers to the ECU do get notified when CAN bus messages are received but when pcan is used for the connection the subscribers do not get notified. Tried a few things and looked at the j1939 library code but cannot figure out the cause.

I was using an earlier version and found this but upgraded to v2.0.5 and the issue remains.

Update: I forgot to check the Closed Issues (sorry) and noticed https://github.com/juergenH87/python-can-j1939/issues/11#issue-1079973075 may address this issue. I did try to add the address in the subscribe but used an integer value. The docs seem to indicate that if the address parameter isn't included then it would notify all subscribers. I'll try this with the hex address and update. I would prefer the approach of notification of all messages if the address isn't included (IMO).

grant-allan-ctct commented 9 months ago

Depending upon which PGNs were not arriving, @jedpop, this might be the same as #57.