jueyang / call-me-maybe

Use the issue queue. Dark secrets welcome. (CUNY-J teaching 2015)
3 stars 0 forks source link

Weird problem with space and MoJo news quiz (again:/) #15

Closed catharob closed 9 years ago

catharob commented 9 years ago

Hey Jue,

This dang newsquiz. I've got it working now (thanks for your help on that!). But I'm having a weird issue that I can't figure out. We're needing to embed a Thinglink hotspotted image for each question, for our quiz about parking. For some reason the quiz is putting in a bunch of extra space below the image and above the questions, which is making it really difficult to read and follow. Here is the live link: http://digitalstorage.journalism.cuny.edu/catherine.roberts/public_html/parking_quiz/index.html

I've hosted it on digital storage right now, but I can push it to git if that's better for you to check it out. Thanks Jue!

Catherine

jueyang commented 9 years ago

Hey @catharob,

If you inspect the elements, you might see that the thinglink images are embedded as iframes, and the iframes are given a set height, thus the space.

This is probably a css problem. I suggest looking into the style sheet that's included in the news quiz template.

On Thu, Mar 12, 2015 at 2:46 PM, catharob notifications@github.com wrote:

Hey Jue,

This dang newsquiz. I've got it working now (thanks for your help on that!). But I'm having a weird issue that I can't figure out. We're needing to embed a Thinglink hotspotted image for each question, for our quiz about parking. For some reason the quiz is putting in a bunch of extra space below the image and above the questions, which is making it really difficult to read and follow. Here is the live link:

http://digitalstorage.journalism.cuny.edu/catherine.roberts/public_html/parking_quiz/index.html

I've hosted it on digital storage right now, but I can push it to git if that's better for you to check it out. Thanks Jue!

Catherine

— Reply to this email directly or view it on GitHub https://github.com/jueyang/call-me-maybe/issues/15.

catharob commented 9 years ago

Thanks Jue! It was the iframe size after all. Fixed now!

On Fri, Mar 13, 2015 at 12:07 PM, Jue Yang notifications@github.com wrote:

Hey @catharob,

If you inspect the elements, you might see that the thinglink images are embedded as iframes, and the iframes are given a set height, thus the space.

This is probably a css problem. I suggest looking into the style sheet that's included in the news quiz template.

On Thu, Mar 12, 2015 at 2:46 PM, catharob notifications@github.com wrote:

Hey Jue,

This dang newsquiz. I've got it working now (thanks for your help on that!). But I'm having a weird issue that I can't figure out. We're needing to embed a Thinglink hotspotted image for each question, for our quiz about parking. For some reason the quiz is putting in a bunch of extra space below the image and above the questions, which is making it really difficult to read and follow. Here is the live link:

http://digitalstorage.journalism.cuny.edu/catherine.roberts/public_html/parking_quiz/index.html

I've hosted it on digital storage right now, but I can push it to git if that's better for you to check it out. Thanks Jue!

Catherine

— Reply to this email directly or view it on GitHub https://github.com/jueyang/call-me-maybe/issues/15.

— Reply to this email directly or view it on GitHub https://github.com/jueyang/call-me-maybe/issues/15#issuecomment-79084255 .