juftin / camply

camply, the campsite finder ⛺️ - a tool to find campsites at sold out campgrounds through sites like recreation.gov

https://juftin.com/camply/

MIT License

468 stars 90 forks source link

✨ Add support for Ntfy notifications #248

Closed ethan-leba closed 1 year ago

ethan-leba commented 1 year ago

See https://ntfy.sh

Description

Adds support for ntfy.sh, which is extremely easy to set up! The other providers have a bit more friction or are paid.

Has This Been Tested?

Tested manually!

Checklist:

[X] I've read the contributing guidelines of this project
[X] I've installed and used .pre_commit on all my code
[X] I have documented my code, particularly in hard-to-understand areas
[X] I have made any necessary corresponding changes to the documentation

juftin commented 1 year ago

Oh this is cool. Excited to try it out

juftin commented 1 year ago

:tada: This PR is included in version 0.19.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

ethan-leba commented 1 year ago

Hey @ethan-leba I just added some small docs updates for this: 318b161

I tested this out successfully with
camply test-notifications --notifications ntfy --debug
Side note, I'm a big fan of ntfy. I've never seen this before and it looks like it'll probably become my recommended notification solution. Thank you for the contribution and tip on this awesome service.

Thanks for cleaning up the PR! And yeah, ntfy is great! I saw it on hacker news a couple months ago, its pretty perfect for personal notification use cases.