juftin / camply

camply, the campsite finder ⛺️ - a tool to find campsites at sold out campgrounds through sites like recreation.gov

https://juftin.com/camply/

MIT License

476 stars 93 forks source link

:sparkles: Discord notification provider #280

Open ajvpot opened 1 year ago

ajvpot commented 1 year ago

Description

Adds a notification provider for Discord. The user needs to provide a webhook URL similar to Slack.

Has This Been Tested?

Yes

Checklist:

[x] I've read the contributing guidelines of this project
[x] I've installed and used .pre_commit on all my code The linter returns some errors on code I didn't change in this PR, ignored those.
[x] I have documented my code, particularly in hard-to-understand areas
[x] I have made any necessary corresponding changes to the documentation

juftin commented 1 year ago

Love this. I'm on an extended trip right now so I'm be a bit slow for review. I will be back home and have final review on this within a couple weeks. Everything looks very good though, thank you for the contribution!

ajvpot commented 1 year ago

Hey @juftin, hope your vacation went well! Please let me know if there's anything I can update on this.

samuelrey commented 4 months ago

Any updates here? The discord integration would be useful. Happy to pick this up & run, but def don't want to step on any feet!

juftin commented 4 months ago

I haven't spent any time on this, I can take a closer look soon though. In the meantime Discord notifications are supported via the AppRise notification provider

https://juftin.com/camply/command_line_usage/#send-a-notification-using-apprise-compatible-services

https://github.com/caronc/apprise

samuelrey commented 3 months ago

This was my first time using Apprise, but it was easier to setup than I thought.

There may be some additional behavior that this PR adds, but I haven't read it in depth at this point.

For future readers, create a webhook on your discord server, copy the URL and set APPRISE_URL with that value (either with camply configure or export APPRISE_URL={my_discord_webhook}). You can then run the test-notification command straight away.