juftin / camply

camply, the campsite finder ⛺️ - a tool to find campsites at sold out campgrounds through sites like recreation.gov
https://juftin.com/camply/
MIT License
464 stars 89 forks source link

--start-date argument not getting respected #318

Closed NiklasKK closed 7 months ago

NiklasKK commented 7 months ago

Describe the bug

The --start-date argument was not working as intended. I provided 2024-04-19 as start date, but received a Pushover notification for a night from the 17th to the 18th.

Original Camply Command

camply campsites --campground 232447 --campground 232449 --start-date 2024-04-19 --end-date 2024-04-21 --notifications pushover --search-forever

Expected behavior

I expected to not get a notification for any nights before the 19th.

Console Output (with --debug)

No console output as I am running it in the background.

Additional context

This is a screenshot of the Pushover notification I received:

IMG_FEB384CDA875-1

juftin commented 7 months ago

Is this behavior consistent or intermittent?

NiklasKK commented 7 months ago

I'm pretty sure I saw it happen multiple times but sadly I deleted the Pushover notifications, but will definitely take another screenshot if I see it happening again.

juftin commented 7 months ago

FWIW I ran through the following commands and each time the days returned increases by one as expected while respecting the lower bound:

camply campsites --campground 232447 --campground 232449 --start-date 2024-04-20 --end-date 2024-04-21
camply campsites --campground 232447 --campground 232449 --start-date 2024-04-19 --end-date 2024-04-21
camply campsites --campground 232447 --campground 232449 --start-date 2024-04-18 --end-date 2024-04-21
camply campsites --campground 232447 --campground 232449 --start-date 2024-04-17 --end-date 2024-04-21

Is it possible you had multiple camply searches with different windows running at the same time? I'm spitballing here but keep me posted on if you see the issue occur again

NiklasKK commented 7 months ago

Yeah, you were right. I actually had a copy paste error for my other search where I unintentionally pasted the 232447 campground. So everything working correctly, sorry for the trouble 😄

juftin commented 7 months ago

Thanks for the follow up here!