search

juftin / camply

camply, the campsite finder ⛺️ - a tool to find campsites at sold out campgrounds through sites like recreation.gov
https://juftin.com/camply/
MIT License
476 stars 93 forks source link

why is push disabled on your dockerbuild? #353

Closed KyleSanderson closed 3 months ago

KyleSanderson commented 3 months ago

Describe the bug

https://github.com/juftin/camply/blob/b110eea5992b57b0e84e1b350119b49230e6f574/.github/workflows/docker.yaml#L45

juftin commented 3 months ago

There are two docker image build jobs in CI/CD. The one that you linked is a job titled docker-ci-test which is simply a test that ensures the image can built:

https://github.com/juftin/camply/blob/b110eea5992b57b0e84e1b350119b49230e6f574/.github/workflows/docker.yaml#L45

The second job is titled docker-hub-publish and is located in the publish.yaml workflow. This where the artifact is pushed after a release is generated:

https://github.com/juftin/camply/blob/6a00c1bc4ddd65e7b9ba06166042d5c32e874fcd/.github/workflows/publish.yaml#L72-L77

KyleSanderson commented 3 months ago

The second job is titled docker-hub-publish and is located in the publish.yaml workflow. This where the artifact is pushed after a release is generated:

https://github.com/juftin/camply/blob/6a00c1bc4ddd65e7b9ba06166042d5c32e874fcd/.github/workflows/publish.yaml#L72-L77

Ah! You're still using Docker Hub! Would it be possible to also push to GitHub Packages? I was looking for one, didn't find one, and ended up making my own. Would much rather prefer to stay on the upstream image.

juftin commented 3 months ago

Yep, publishing to Docker Hub is part of the release process: https://hub.docker.com/r/juftin/camply

I'd consider using the GitHub Docker Container Registry, but would probably prefer just to use a single registry. Any reason why you prefer to pull an image from GitHub instead of Docker Hub?

KyleSanderson commented 3 months ago

I just didn't see it on the RHS (packages) and there was no mention of docker in the readme.md