search

juftin / hatch-pip-compile

hatch plugin to use pip-compile (or uv) to manage project dependencies and lockfiles
http://juftin.com/hatch-pip-compile/
MIT License
76 stars 3 forks source link

🧪 initial tests #28

Closed juftin closed 10 months ago

juftin commented 10 months ago

Summary

This PR adds some initial tests to the hatch-pip-compile plugin. The tests are a start and coverage isn't complete yet - more to come later.

Test fixtures were adapted from hatch's fixtures: https://github.com/pypa/hatch/blob/master/tests/conftest.py

Relates to #18

juftin commented 10 months ago

:tada: This PR is included in version 1.8.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

oprypin commented 10 months ago

Mm I find it quite unreasonable that this pull request constitutes a release https://github.com/juftin/hatch-pip-compile/releases/tag/v1.8.0 and the release notes basically should be empty because to users this is just noise

juftin commented 10 months ago

I actually debated on whether or not to trigger a release for this, ultimately since https://github.com/juftin/hatch-pip-compile/commit/e39e82d changed the code-path and needed a version increment. Right now my release mechanism only has patch releases for bug commits - and this wasn't a bug. Do you think this should've been a non-release change?

Good to know that you felt the release notes included noise - that can be cut back.

oprypin commented 10 months ago

I see the point about the code path.. But I think that actually doesn't make sense. Just declare that this codebase is not meant to be used as an import in Python and that's that 😃

oprypin commented 10 months ago

Or maybe I misunderstood what you meant..

semantic-release seems to define ✨ as something greater than a bugfix whereas this I think was something lesser than a bugfix because there's 0 impact for users

juftin commented 10 months ago

That commit was probably something like 🎨 (code tidying) which didn't warrant a release - but some calls to self.platform got changed to self.virtual_env.platform so I ended making the call to push a release.

I get your point though - that shouldn't happen again.

oprypin commented 10 months ago

Hmm well if it was a change in behavior then I guess it should be described, but the description is "plugin command runner". I actually didn't understand that this is a change.

Anyway just thoughts out loud