juftin / lunchable

Python Client for the Lunch Money Developer API

https://juftin.com/lunchable/

MIT License

37 stars 8 forks source link

🐛 split amount must be positive #86

Closed ericzinnikas closed 1 year ago

ericzinnikas commented 1 year ago

Description

Prior to this fix, running lunchable plugins splitlunch splitlunch-import --tag-transactions --financial-partner-id 123 --financial-partner-group-id 456 failed with:
```
LunchMoneyHTTPError: ['Sums of split transaction do not add up to the original transaction amount!']
```
For SplitLunchImport tagged items, this failed to create the 2nd reimbursement split, as the financial_impact (and thus split amount) was negative

Has This Been Tested?

Ran lunchable plugins splitlunch splitlunch-import, see Splitwise transaction created, but Lunchmoney split failed
Add abs
Re-run, see Splitwise transaction and Lunchmoney split succeed

Checklist:

[X] I've read the contributing guidelines of this project
[X] I've installed and used .pre_commit on all my code
[X] I have documented my code, particularly in hard-to-understand areas
[ ] I have made any necessary corresponding changes to the documentation

juftin commented 1 year ago

:tada: This PR is included in version 0.8.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: