search

jugaad-py / jugaad-data

Download live and historical data for Indian stock market
https://marketsetup.in/documentation/jugaad-data/
373 stars 147 forks source link

URL Changed By NSE to nsearchives.nseindia.com Please Update this ASAP. #56

Open silenThunderr opened 1 year ago

silenThunderr commented 1 year ago

https://github.com/jugaad-py/jugaad-data/blame/c6a6427dc8041ef26c086690c85c46f2d83dcf2a/jugaad_data/nse/archives.py#L25C5-L25C47

New Base URL to be updates is : https://nsearchives.nseindia.com/

https://github.com/jugaad-py/jugaad-data/blob/c6a6427dc8041ef26c086690c85c46f2d83dcf2a/jugaad_data/nse/archives.py#L24

class NSEArchives: base_url = "https://archives.nseindia.com" """Conventions

pallasite99 commented 1 year ago

@silenThunderr I have made the changes here: https://github.com/jugaad-py/jugaad-data/pull/57

Although I am not sure how to test this locally hence relying on your original ticket description for scope of changes.

pallasite99 commented 1 year ago

@sevakram PTAL when possible, thanks.

Although I am not able to access either URL provided in the ticket (the existing one in codebase and the new one)