search

jugeeya / UltimateTrainingModpack

An application to drastically improve the training mode in Super Smash Bros. Ultimate.
361 stars 48 forks source link

DJ rings are missing with hitboxes visualization On #422

Open gnaomo opened 1 year ago

gnaomo commented 1 year ago

Used to be fixed with #37 ezgif-2-2d2efd4291

jugeeya commented 1 year ago

Somehow an old code refactor removed this (https://github.com/jugeeya/UltimateTrainingModpack/pull/83/files)

Added again here: https://github.com/jugeeya/UltimateTrainingModpack/commit/ccac7c958d2bb10fe98471eab4179b584f6ff13f

gnaomo commented 1 year ago

i checked latest beta but it's still not fixed 😢

gnaomo commented 1 year ago

well i found out that rings only appear if a dj and an aerial animation starts on the same frame

ezgif-4-6a249fee09

austintraver commented 1 year ago

@gnaomo I'm still familiarizing myself with the codebase, so take this with a grain of salt, but perhaps this might be the intended behavior of the game?

Reference: PSA: The double jump ripple doesn't show up if you input an aerial on the first frame after double jumping

--Reddit

Are we certain this behavior is caused by the training mod?

gnaomo commented 1 year ago

What I was trying to say is that DJ rings still did not show up, always, with hitbox vis. on (I don't know now on latest beta) even after jugeeya's commit ccac7c9

That gif was a different thing, sorry if I've may confused things. It's an interesting side effect to the main bug of this issue thread, but I would not call that a TMP fault