jugeeya / UltimateTrainingModpack

An application to drastically improve the training mode in Super Smash Bros. Ultimate.
354 stars 47 forks source link

Increase Resilience to Game Updates by Dynamically Finding Offsets #661

Closed asimon-1 closed 8 months ago

asimon-1 commented 9 months ago

This PR introduces the offsets.rs file which dynamically searches the smash binary for the location of functions we want to hook, instead of utilizing a static offset. Static offsets are known to break when the game is updated, whereas the specific instructions are expected to be more stable.

I have not noticed a significant increase in boot time due to this binary searching, so no need to put it behind a feature flag.