search

jugglingcats / tachograph-reader

Read driver and vehicle card data and convert to a more usable XML format
80 stars 61 forks source link

Correctly group SpecificConditionRecords #33

Closed davispuh closed 6 years ago

davispuh commented 6 years ago

Currently they all are like

<SpecificConditions>
  <SpecificConditionRecord>
        <EntryTime DateTime=""/>
        <SpecificConditionType>1</SpecificConditionType>
        <EntryTime DateTime=""/>
        <SpecificConditionType>2</SpecificConditionType>
  </SpecificConditionRecord>
</SpecificConditions>

this PR fixed it so it's

<SpecificConditions>
  <SpecificConditionRecords>
    <SpecificConditionRecord>
        <EntryTime DateTime=""/>
        <SpecificConditionType>1</SpecificConditionType>
    </SpecificConditionRecord>
    <SpecificConditionRecord>
        <EntryTime DateTime=""/>
        <SpecificConditionType>2</SpecificConditionType>
   </SpecificConditionRecord>
  </SpecificConditionRecords>
</SpecificConditions>
jugglingcats commented 6 years ago

Hi @davispuh, I have added you as a collaborator to this project so feel free to merge your pull requests (or others!). I don't have time at the moment to review each pull request so better if you can do it directly. Hope this works for you. Thanks for your efforts.

davispuh commented 6 years ago

Yeah, sure, thanks! 👍 😃