search

juglab / cryoCARE_pip

PIP package of cryoCARE
BSD 3-Clause "New" or "Revised" License
26 stars 14 forks source link

Create path before saving training data to disk #8

Closed thorstenwagner closed 2 years ago

thorstenwagner commented 2 years ago

The folder config['path'] should be created before saving training data to disk. Otherwise it will crash.

tibuch commented 2 years ago

Makes sense. Do we need to worry about overwriting existing results?

thorstenwagner commented 2 years ago

One option would be to not allow overwriting results by default, but add a variable to the config file to allow it?

tibuch commented 2 years ago

This sounds like a great solution to me, which would be backwards compatible.

thorstenwagner commented 2 years ago

Done, I've added the option. I did the same for predict, but this will be merged together with mpido version.

I would merge it if you are happy with the implementation.