juglab / n2v

This is the implementation of Noise2Void training.
Other
392 stars 107 forks source link

Pin Tensorflow and Keras version numbers in README instructions #54

Closed GenevieveBuckley closed 4 years ago

GenevieveBuckley commented 4 years ago

The code in the README for creating the conda environment are not pinned to any specific version of Tensorflow and Keras, even though descriptions in the text above and below stress the importance of only using specific compatifble versions. I think it would be a smoother experience for new users if those versions were also pinned explicitly with conda.

Right now if you create a Python 3.6 conda environment and conda install tensorflow-gpu and keras into it unpinned (i.e. like the current code snippet in the readme) then you get Tensorflow version 2, which is incompatible with noise2void.

Note: it also seems like there might be a small typo in the sentence about the keras version number, should this read "... version of keras be 2.2.4 or 2.2.5" instead of "... version of keras be 2.24 or 2.2.5"?

Previous related issues: https://github.com/juglab/n2v/issues/39

tibuch commented 4 years ago

Thank you!