Tools menu

[haesleinhuepf]

Hi Joran @jdeschamps ,

here comes a PR for making the denoising work from the Assistant / Tools menu as discussed here:

• https://github.com/juglab/napari-n2v/issues/6

Some things here are optional, but step by step:

• You should at least take over this change which was necessary to make the function work:

https://github.com/haesleinhuepf/napari-n2v/blob/d93c9fb54d9a473ac64ad8e43035d4cf673733be/src/napari_n2v/utils/prediction_worker.py#L39

• I changed the model_filename parameter from type str to PathLike which adds the Select File button to the generated GUI:

This change avoids the denoiser being shown in the assistant at the moment. I will fix this on the Assistant side: https://github.com/haesleinhuepf/napari-assistant/issues/34

• A little warning: The register_function needs napari_tools_menu, which was not in the requirements:

https://github.com/haesleinhuepf/napari-n2v/blob/d93c9fb54d9a473ac64ad8e43035d4cf673733be/src/napari_n2v/utils/prediction_worker.py#L22

https://github.com/haesleinhuepf/napari-n2v/blob/d93c9fb54d9a473ac64ad8e43035d4cf673733be/setup.cfg#L46

• Now comes the optional part: The napari-tools-menu is only compatible with napari <= 0.4.15 (See also). That's why these changes are necessary:

https://github.com/haesleinhuepf/napari-n2v/blob/d93c9fb54d9a473ac64ad8e43035d4cf673733be/setup.cfg#L47-L51

There is an alternative: You could remove the dependency to napari-tools-menu as proposed in this PR:

• https://github.com/haesleinhuepf/napari-n2v/pull/1

However, let me pitch the tools menu for a moment. We know well that users are confused from the plugins menu. It is hard to find things there because of its chaotic ordering:

I'm claiming that functionality is easier to find the Tools menu:

The drawback is pinning napari<=0.4.15 . It comes with the advantage though that updates to napari-core cannot break our plugins 🌞

Let me know what you think!

Best, Robert

[jdeschamps]

Thanks a lot for the PR!