juglab / napari-n2v

A self-supervised denoising algorithm.
https://juglab.github.io/napari-n2v/
BSD 3-Clause "New" or "Revised" License
24 stars 3 forks source link

napari 0.4.15 vs 0.4.16 #15

Closed jdeschamps closed 1 year ago

jdeschamps commented 1 year ago

Currently tests do not run with napari 0.4.15 but https://github.com/juglab/napari-n2v/pull/14 fixed dependency to 0.4.15 (and visp).

Reason for failing tests are mostly because we use show_error from napari.utils.notifications (napari 0.4.16). This should be easy to correct. Another failing test is due to numpy arrays.

I now relaxed the dependency to have the tests pass.

Next:

jdeschamps commented 1 year ago

Currently decided to stick with 0.4.15 and fixed the errors in https://github.com/juglab/napari-n2v/commit/a3e2bf596f4789a2a76cb35dcd3b7a4aa817973e and https://github.com/juglab/napari-n2v/commit/b287662ef9f880d06ce2827ea96a42fd8a8d2084.