jugshaurya / merge-videos

😁😁 Merge Videos inside a directory into a single video :) Doesn't matter how deep are they hidden.
MIT License
7 stars 2 forks source link

BUG: "videoConcat" not defined #2

Closed wise-introvert closed 3 years ago

wise-introvert commented 3 years ago

Looks like the method call videoConcat({...}) doesn't have an origin: Broken code-block:

...
const mergeVideos = (files) => {
  // TODO: show the progress bar
  videoConcat({
    silent: true, // optional. if set to false, gives detailed output on console
    overwrite: true, // optional. by default, if file already exists, ffmpeg will ask for overwriting in console and that pause the process. if set to true, it will force overwriting. if set to false it will prevent overwriting.
  })
    .clips(
      files.map((file) => ({
        fileName: file,
      }))
    )
    .output(join(__dirname, "output", "congrats.mp4"))
    .concat()
    .then((outputFileName) => {
      console.log("Congrats your file is generated inside output folder");
      console.log(outputFileName);
    })
    .catch((err) => {
      console.log("Something went wrong so sorry!");
      console.log("Error:", err);
    });
};
...

Error: image

jugshaurya commented 3 years ago

Thank you @wise-introvert for reporting it, was trying something else, deleted the line by mistake. Fixed it. also changed steps to include npm install. Do check that out if you missed that.
Here: https://github.com/jugshaurya/merge-videos/commits/main

wise-introvert commented 3 years ago

@jugshaurya Great! I've opened up a PR for the progress-bar feat, however, the recent push has created a merge conflict. I'll fix them and push a patch.

BTW: Great idea, beautifully executed. Kudos to you!

jugshaurya commented 3 years ago

@wise-introvert Thank you, still working on some problems in this project. Videos with very long path names resulting in erroneous video merging or no merging.Will fix it in the future. Hope it helps.