search

jugyo / SublimeColorSchemeSelector

Sublime Text Plugin to select theme quickly via the Quick Panel.
41 stars 10 forks source link

only default schemes available #1

Closed darkhouse closed 11 years ago

darkhouse commented 11 years ago

It would be nice if it recognized all schemes in all folders instead of just the default ones.

dennisbot commented 11 years ago

actually I've extended the plugin to do that, but I'm new to github and I didn't have time to learn how to make pull request and how to package my improvement so I would like some guidelines on this matter to properly share my improvement, I mean what darkhouse is saying!, hope someone replies. (what I did is look for "colour scheme directory using regular expressions and give the full path to the related directory)

darkhouse commented 11 years ago

All you have to do is fork the repository so that you have your own version in your github account. Then you would clone it to your local machine, make your changes, commit and push it back. Then you'd go and create a pull request, and that's it. If it's accepted, great, if not, we can always just grab yours and use it instead :D

dennisbot commented 11 years ago

:O I thought it should be in one place xD, well I'll do it now, it will be my first contribution to the world :)

dennisbot commented 11 years ago

ok!, is ready to go!

darkhouse commented 11 years ago

awesome, add your pull request and you're done

dennisbot commented 11 years ago

:O so now we have to wait until jugyo see this request?, I did the pull request, and is waiting to merge

darkhouse commented 11 years ago

yep. thats it

jugyo commented 11 years ago

I'm sorry to reply late. Now I've implemented the feature: 09c6d97