search

jugyo / earthquake

Twitter terminal client with streaming API support.
MIT License
661 stars 94 forks source link

work around JRuby String.encode! issue #139

Closed frasertweedale closed 10 years ago

frasertweedale commented 12 years ago

JRuby 1.6.7.2 (Ruby 1.9 mode) seems to have a bug in String.encode! resulting in Encoding::ConverterNotFoundError being raised, however, String.encode does not have this problem.

Call String.encode rather than String.encode! to dispel this error.

frasertweedale commented 10 years ago

I'm not sure if this is still an issue in JRuby but the patch surely does no harm.

But if you don't care about JRuby support (I did when I wrote the patch but don't anymore) then feel free to close the PR.

frasertweedale commented 10 years ago

closed due to inactivity and probable irrelevance by now :)