juhaku / utoipa

Simple, Fast, Code first and Compile time generated OpenAPI documentation for Rust
Apache License 2.0
2.21k stars 170 forks source link

Switch to using cargo-make #1040

Open jayvdb opened 1 week ago

jayvdb commented 1 week ago

Would you be interested in me replacing test.sh with a Makefile.toml

https://github.com/sagiegurari/cargo-make

I can do all the CI stuff to make this work.

juhaku commented 1 week ago

Why not, I have been actually weighting upon that or justfile or just plain make. :laughing: But I haven't got anywhere with that choice. Sure if you want to set things up that would be great. That test file get's anyway quite cumbersome to maintain. One thing to add is probably coverage as well at somepoint but haven't really got to it.

juhaku commented 1 week ago

Like what ever is the scripts could be migrated to the either of those options. And cargo make is one feasible option.

jayvdb commented 1 week ago

Both cargo-make and just are supported by https://github.com/taiki-e/install-action/blob/main/TOOLS.md , which speeds up the CI installing of the tool.

just has more stars - I havent used that yet, so I will try it first.

juhaku commented 1 week ago

Yeah, sure thing, for what I understand the justfile basically 60 % makefile and then the rest is build on top of it to enhance the quirks of old fashioned makefile to give smooth command running experience.

For example the acitx-web is using justfile