search

juhanakristian / remix-auth-microsoft

Microsoft authentication strategy for remix-auth
MIT License
37 stars 19 forks source link

Inconsistent parameters in MicrosoftStrategyOptions #10

Closed im-neil closed 1 year ago

im-neil commented 1 year ago

Why don't the parameters for MicrosoftStrategyOptions in this GitHub repository match those in the npm package?

1) src/index.ts (this repository, version 1.03)

export interface MicrosoftStrategyOptions { clientId: string; clientSecret: string; redirectUri: string; scope?: string; tenantId?: string; prompt?: string; }

2) node_modules/remix-auth-microsoft/build/index.d.ts
(version 1.03 as installed using npm install remix-auth-microsoft remix-auth remix-auth-oauth2 @remix-run/server-runtime)

export interface MicrosoftStrategyOptions { clientID: string; clientSecret: string; callbackURL: string; scope?: string; tenant?: string; prompt?: string; }

juhanakristian commented 1 year ago

Hi @im-neil and thanks for reporting the issue. The repository does indeed have different parameter names because they are going to be changed in the next version bu package version in the repo hasn't been updated yet. Sorry for the inconvenience.

juhanakristian commented 1 year ago

This has now been resolved in v2.0.0