search

juhasch / pyBusPirateLite

Python library for BusPirate
https://pybuspiratelite.readthedocs.io/en/latest/
Other
59 stars 32 forks source link

Fix BusPirate.response() regression from API change #22

Closed HansAnderson closed 5 years ago

HansAnderson commented 5 years ago

Commit 4f8ae283e87b79706a726b84485cd75e650d4c8d changed the definition of BBIO_Base.response() (BBIO_Base was later renamed to BusPirate) such that the second argument went from a boolean that indicates that data should be returned to a boolean that indicates if the data should be decoded. There were a few cases where the old meaning was still assumed.

To prevent a similar bug, all instances of response() with a second argument now use a keyword argument.

juhasch commented 5 years ago

Thank you. This hit me also when testing other open PRs