search

juhinagpure / Eduford-university

71 stars 170 forks source link

Added dark mode feature #340

Closed Max3796 closed 4 months ago

Max3796 commented 4 months ago

I've made the necessary adjustments and included a toggle button to switch between dark and light modes.

Light mode:

Screenshot 2024-06-28 180617

Dark mode:

Screenshot 2024-06-28 180652
Max3796 commented 4 months ago

@CodiumAI-Agent /review

CodiumAI-Agent commented 4 months ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5] 3
🧪 Relevant tests No
🔒 Security concerns No
⚡ Key issues to review Possible Bug:
The event listener for storing the theme preference is attached to the .toggle-circle which might not be the intended element since the theme toggle functionality is likely intended to be triggered by the entire .theme-toggle div.
Code Duplication:
The opacity settings for .fa-sun and .fa-moon are repeated in both body.dark-mode and body.light-mode CSS classes. This could be optimized by setting default styles outside of these classes and only overriding them as necessary.