Strip invalid XML characters

juhovh / mocha-jenkins-reporter

Mocha reporter for Jenkins style JUnit reports

MIT License

123 stars 69 forks source link

Strip invalid XML characters #63

Closed toddpi314 closed 7 years ago

toddpi314 commented 7 years ago

Issue: if someone console.logs something in the wide unicode space that isn't compatible with XML spec (ex. \x1b), the report.xml generated will be invalid.

Would you accept a PR that will add a validator that maps to XML 1.0 Character Range specification?

Ref: Extensible Markup Language (XML) 1.0 (Fifth Edition)

jvah commented 7 years ago

If it doesn't break anything else then I'm happy to accept a PR fixing the XML.

sgtcoolguy commented 7 years ago

Relates to #34

jvah commented 7 years ago

@sgtcoolguy @toddpi314 I have just pushed https://github.com/juhovh/mocha-jenkins-reporter/commit/9b232b8d2dffab762bb0e4acf1d3dc98d11ba14e reverting the old changes to master, could you please test it out and I'll make a new release?

jvah commented 7 years ago

Should be fixed now again, did not get any comments.