search

juhovh / shairplay

Apple airplay and raop protocol server
Other
1.35k stars 228 forks source link

[raop] - also forward png data to the coverart callback #36

Closed Memphiz closed 9 years ago

Memphiz commented 9 years ago

as the title says. Well this PR does it in a backwards compatible way. Problem now is that the caller needs to determine the type of the coverart data (i do it via detecting the d8ff and d9ff bytes of an jpeg to detect jpeg and assume png in the else case - in kodi).

The right way would be to alter the callback or add a new callback which has data, size and type i guess. Not sure how you want it...

juhovh commented 9 years ago

Let's merge it like this, I have lots of API breakage coming in the experimental branch with NTP and all, so I'll implement this properly there. Probably matching for "image/*" and adding the mime type to the coverart callback would be a proper solution. So mark your jpeg detection hack with some kind of a comment so that it can be removed when a proper fix is in master branch. :)