Add support for passing the progress values to raop callbacks.

juhovh / shairplay

Apple airplay and raop protocol server

Other

1.35k stars 228 forks source link

Add support for passing the progress values to raop callbacks. #38

Closed Memphiz closed 9 years ago

Memphiz commented 9 years ago

This is the rebased version of your progress branch - ready to merge into master...

juhovh commented 9 years ago

Merged into master, the API might or might not change in the future, but that shouldn't be a huge issue.

Memphiz commented 9 years ago

As an api change suggestion - the dacp id should be passed via the init callback really because its something that won't change during the whole stream session. ;)

juhovh commented 9 years ago

Yeah, I've thought about that. On the other habd it is sent on every RTSP request so in theory it might change, also it is not useful for all users so keeping it in a separate callback that can be just left unimplemented if not needed might be nice as well. Do you need to do some hacks if it's sent after init?

Memphiz commented 9 years ago

nah its fine ;)