search

juhp / fbrnch

Tool to update fedora packages branches
https://hackage.haskell.org/package/fbrnch
GNU General Public License v2.0
23 stars 3 forks source link

fbrnch create-review requires a directory? #12

Closed QuLogic closed 3 years ago

QuLogic commented 3 years ago

I thought it used to accept spec files? But with 0.5-1.fc32, if I run fbrnch create-review R-brio.spec, it says:

fbrnch: No such directory: R-brio.spec

though the file is there.

QuLogic commented 3 years ago

Updated to 0.5-3.fc32, and it still does something like this.

So I moved the file into a subdirectory of ~/rpmbuild/SPECS and it worked better, but not quite right. It created the srpm in ~/rpmbuild/SRPMS (a bit unexpected though fine), but then after openin a Review Request, it started all over again.

juhp commented 3 years ago

(One can run fbrnch create-review without an argument to use the current directory.)

You mean you want to create packages out of SPECS/? Let me think a little on this.

I often wonder about whether to use the rpmbuild default ~/rpmbuild or not. Currently fbrnch just follows one's default settings for (non-distgit): personally I override rpmbuild to use the current directory.

QuLogic commented 3 years ago

Well, in 0.4, it was possible to specify a file and work on that. I have tons of stuff in SPECS, so picking the first file out of there doesn't work at all.

juhp commented 3 years ago

spec filepaths should be supported now in the latest copr build.

QuLogic commented 3 years ago

Yep, working again.