search

juhp / fbrnch

Tool to update fedora packages branches
https://hackage.haskell.org/package/fbrnch
GNU General Public License v2.0
23 stars 3 forks source link

Remove check for git repo in parallel #19

Closed QuLogic closed 3 years ago

QuLogic commented 3 years ago

I have all my packages (for a given topic) as submodules in a parent repo. This stops fbrnch parallel from working because it checks for a git repo in the current directory, and then stops.

juhp commented 3 years ago

Could you give an example (maybe a short shell script to setup a simple version of a case like this)? Then I can try to play with it.

QuLogic commented 3 years ago

For example, I have all my R packages as submodules here: https://pagure.io/fedora-r-specs; I can't run fbrnch parallel pkg1 pkg2 because of the outer git directory.

juhp commented 3 years ago

Anyway I see your point I guess I can try to remove this restriction.

I was curious though if you really meant they are git submodules?

One problem is that currently my clever branch/package selection logic assumes packages should not be inside a dist-git dir. But I can probably do better.

juhp commented 3 years ago

I haven't actually tested, but I believe this should work now in HEAD and coming 0.8.0

juhp commented 3 years ago

For example, I have all my R packages as submodules here: https://pagure.io/fedora-r-specs; I can't run fbrnch parallel pkg1 pkg2 because of the outer git directory.

Ah I see, impressive!

juhp commented 3 years ago

I had forgotten to test your use-case before releasing 0.8.0, but it does seem to work for me.