juhp / fbrnch

Tool to update fedora packages branches
https://hackage.haskell.org/package/fbrnch
GNU General Public License v2.0
23 stars 3 forks source link

Adding %autorelease support #24

Closed LyesSaadi closed 2 years ago

LyesSaadi commented 2 years ago

Hello again :D!

So, I switched some of my packages over to %autorelease, and fbrnch seems unfortunately not to support that. Indeed, it tries to build for release 1 every time %autorelease is set.

juhp commented 2 years ago

Thanks for the report. I am also slowly trying switching some of my packages over... I will try to look into it, but could you please describe an usage example where you see this occur?

juhp commented 2 years ago

Did you mean for fbrnch local or fbrnch build? For the former at least I think it is expected: though some workaround might be possible.

(BTW I checked in Koji and didn't find any recent builds of yours there exhibiting the issue.)

LyesSaadi commented 2 years ago

It was for badwolf. You didn't see the build because I did an error in 1.2.0-1 (forgot to add a git message (fedpkg ci -c => It put « local build »), and thus releasing a build without changelog), tried to fix it by submitting 1.2.0-2 as an empty commit, which failed as fbrnch refused to submit it, saying 1.2.0-1 was already built, and then had to submit 1.2.0-3 fixing everything (adding changelog entries to explain the update) and then submitted it through fedpkg.

juhp commented 2 years ago

Thanks for the explanation, that helps a lot.

So I think I need to improve the nvr check when using %autorelease.

michel-slm commented 2 years ago

Looking forward to a release that supports this! Coupled with #25 I think I'll have to postpone using fbrnch for my parallel builds

juhp commented 2 years ago

Okay thanks for the poke - a new release is long overdue.

Still hoping to get it out this month...

juhp commented 2 years ago

fbrnch-1.0.0 is out now btw and coming shortly to Fedora.

juhp commented 2 years ago

It is in updates-testing and development releases now.

juhp commented 2 years ago

I am adding a few more rpmautospec fixes in the next coming release, which I hope will be out soonish.

After that I will probably close this, but do please report any more issues you see.

juhp commented 2 years ago

I released 1.1