The update command does not work with http clone

juhp / fbrnch

Tool to update fedora packages branches

https://hackage.haskell.org/package/fbrnch

GNU General Public License v2.0

23 stars 3 forks source link

The update command does not work with http clone #27

Open TristanCacqueray opened 2 years ago

TristanCacqueray commented 2 years ago

Hi, it seems like the update command does not work with package cloned over http.

Here is what I did:

git clone https://src.fedoraproject.org/rpms/supercollider
update the version field of the specfile
run fbrnch update

Here is what I got:

3.12.0
-> 3.12.2

Here is what I expected:

Finalizing the specfile (set Release back to 0 and add changelog entry)
Fetching the source with spectool
Updating the sources file
Uploading the new source to the lookaside cache

And perhaps the tool could have reminded me that:

run fedpkg scratch-build --srpm to build in koji
then run fedpkg push to submit the update
then see this other doc to backport the change to a release branch

juhp commented 2 years ago

Currently I think it mostly works for repos cloned over ssh. (There might be some unreleased tweaks for this in git - not sure have to check the logs.)

TristanCacqueray commented 2 years ago

Here is the clone's .git/config:

[core]
    repositoryformatversion = 0
    filemode = true
    bare = false
    logallrefupdates = true
[remote "origin"]
    url = https://src.fedoraproject.org/rpms/supercollider
    fetch = +refs/heads/*:refs/remotes/origin/*
[branch "rawhide"]
    remote = origin
    merge = refs/heads/rawhide

juhp commented 2 years ago

I would recommend though to use fbrnch clone or at least fedpkg clone, which both default to ssh.

You are correct that https does work too apparently - whereas I was simplifying/assuming a https repo to be an anonymous checkout.

juhp commented 2 years ago

Maybe some user config could be added: like "prefer-https-to-ssh". I probably won't get it that soon though.

It is also useful to have support for "anonymous checkouts" (eg if you are working on a host without your ssh keys or not a Fedora packager), and https: is probably the main way to do that currently (maybe git: also works).

juhp commented 2 years ago

And perhaps the tool could have reminded me that:
* run `fedpkg scratch-build --srpm` to build in koji

(You mean fbrnch scratch

* then run `fedpkg push` to submit the update

and fbrnch build ? ;o)

But I do like your idea of suggesting next steps... that would be friendly - let me see later...

juhp commented 1 year ago

Just noting this page here: https://fedoraproject.org/wiki/Infrastructure/HTTPS-commits