search

juhp / fbrnch

Tool to update fedora packages branches
https://hackage.haskell.org/package/fbrnch
GNU General Public License v2.0
23 stars 3 forks source link

Fix create-review with different username/fasid #34

Closed LyesSaadi closed 2 years ago

LyesSaadi commented 2 years ago

Hey !

I think this was an oversight? When creating a new review, it fails to upload to fedorapeople if your username and fasid are different because ssh takes the username by default. This was handled properly by the line above it.

gotmax23 commented 2 years ago

I also have this issue. I am currently working around it with

$ grep -A 1 fedorapeople ~/.ssh/config                                                        
Host fedorapeople.org
    User gotmax23

but it would be nice if this worked without that. Thanks for fixing it!

juhp commented 2 years ago

Thank you for this!

juhp commented 2 years ago

Good catch - thanks for the fix!

Glad to know that you are both using create-review. :)